Clean up Client variables
#419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are sparsely used and badly named, so probably not externally depended on externally
We have a setter method for them, so there should be no need to access these directly!
Modifying `uid` was previously documented as giving undefined behaviour, now it'll throw an error
These have complicated semantics, and so are hopefully not depended on externally
These have complicated semantics, and so are hopefully not depended on externally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #406
A lot of changes to the variables in
Client:Privatized:
default_thread_iddefault_thread_typeclient_idfb_hseqreq_counterpayloadDefaultpoolstickyRemoved:
clientuser_channelstart_timettstampfb_dtsgemailpasswordSo now the following variables remain:
uid- A readonly documented@propertyreq_url- Known external dependency, see Allow to connect to Facebook through TOR #403ssl_verify- Documentedlistening- DocumentedSo overall, this is a breaking change, but it only changes undocumented variables, so I'll just bump the minor version number.