Undocumented breaking changes #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file, and contained functions, were explicitly documented as something you couldn't rely on for backwards compatibility
Undocumented
Undocumented
madsmtm
added a commit
that referenced
this pull request
Jun 23, 2019
- Removed / privatized a lot of undocumented functionality, which might break some users application if they were relying on those (hence the minor version bump). See #432 for further reasoning - Add `Client.forwardAttachment` and `Message.forwarded` attribute, see #420 - Fix parsing subattachments with no target, see #412 - Lots of other refactoring, aka. work on the transition towards v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed my mind since #419, #406 and #405, I believe all undocumented items should be considered private per default. The reason is mostly that without this, it'll be very hard for me to make further internal improvements (especially
Client.req_urlis annoying).In the future, I'll explicitly document what is considered a breaking change, but for now, I'll "cheat" a little.