Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in binning comparison target in graph_numeric.py #172

Open
SadieRobertson opened this issue Mar 22, 2024 · 0 comments
Open

Bug in binning comparison target in graph_numeric.py #172

SadieRobertson opened this issue Mar 22, 2024 · 0 comments

Comments

@SadieRobertson
Copy link

When using sweetviz.compare() on two identical datasets, we found that the target line plot in numerical graphs would not match up for the final bin. On taking a look at the code we noticed that a step is missed when binning the compare dataset target. In graph_numerical.py we noticed that on line 118 that the step to add data points which fall outside the bin range to the final bin is repeated for the source dataset instead of being carried out for the compare dataset. Swapping this to the compare data set solves the issue.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant