micro-optimization: use int8 for enums (#338)

Author: drakkan

asciiconverter.go

@@ -5,7 +5,7 @@ import (
 	"io"
 )
 
-type convertMode int
+type convertMode int8
 
 const (
 	convertModeToCRLF convertMode = iota

client_handler.go

@@ -14,7 +14,7 @@ import (
 )
 
 // HASHAlgo is the enumerable that represents the supported HASH algorithms
-type HASHAlgo int
+type HASHAlgo int8
 
 // Supported hash algorithms
 const (
@@ -26,7 +26,7 @@ const (
 )
 
 // TransferType is the enumerable that represents the supported transfer types
-type TransferType int
+type TransferType int8
 
 // Supported transfer type
 const (
@@ -35,7 +35,7 @@ const (
 )
 
 // DataChannel is the enumerable that represents the data channel (active or passive)
-type DataChannel int
+type DataChannel int8
 
 // Supported data channel types
 const (

driver.go

@@ -208,7 +208,7 @@ type PortRange struct {
 type PublicIPResolver func(ClientContext) (string, error)
 
 // TLSRequirement is the enumerable that represents the supported TLS mode
-type TLSRequirement int
+type TLSRequirement int8
 
 // TLS modes
 const (
@@ -219,7 +219,7 @@ const (
 
 // DataConnectionRequirement is the enumerable that represents the supported
 // protection mode for data channels
-type DataConnectionRequirement int
+type DataConnectionRequirement int8
 
 // Supported data connection requirements
 const (

driver_test.go

@@ -17,7 +17,7 @@ import (
 	"github.com/spf13/afero"
 )
 
-type tlsVerificationReply int
+type tlsVerificationReply int8
 
 const (
 	// tls certificate is ok but a password is required too