Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler API #5

Open
ivogabe opened this issue Mar 7, 2015 · 4 comments
Open

Compiler API #5

ivogabe opened this issue Mar 7, 2015 · 4 comments

Comments

@ivogabe
Copy link

ivogabe commented Mar 7, 2015

I've been trying to make my gulp-typescript compatible with multiple versions of TypeScript. I also tried it with your fork of TypeScript, but that didn't work. The Program interface has changed between TS1.4 and the current master. I've made my plugin compatible with both of them, but it looks like your fork has an API between those two.. The type checking by TypeScript does work with the typescript.d.ts file from your fork, but at runtime I get this error:

var emitErrors = checker.emitFiles().diagnostics;
TypeError: undefined is not a function

I think merging the master from Microsoft would do the trick, can you do that?

You can test it with the jsx-typescript branch from gulp-typescript by running gulp.

@fdecampredon
Copy link
Owner

I planned to wait the release branch 1.5 but yeah I can merge master with my current fork I'll try do do so when I have a little time.

@basarat
Copy link

basarat commented Mar 7, 2015

I think on master emitFiles was moved to program from checker. This is based purely on feeling and not actual code review ❤️

@wingedkiwi
Copy link

Confirmed I just ran into the same issue.

@iongion
Copy link

iongion commented Apr 2, 2015

Hit this also

@iongion iongion mentioned this issue Apr 3, 2015
fdecampredon pushed a commit that referenced this issue Apr 8, 2015
New TextStreamWriter interface with JSDoc and additional members
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants