Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon contribution: Color #786

Open
DawnPaladin opened this issue Nov 21, 2019 · 8 comments · May be fixed by #799
Open

Icon contribution: Color #786

DawnPaladin opened this issue Nov 21, 2019 · 8 comments · May be fixed by #799

Comments

@DawnPaladin
Copy link

Icon contribution

  • Icon name: Color
  • Use case: Selecting colors or themes
  • Alternate names: paint, theme

I needed an icon for my app to let users choose between several themes with different colors. Here's what I made:

image
image

  1. Maximum readability. Technically conforms to the guidelines, but not fully in the Feather style.
  2. Compromise between readability and style
  3. Full Feather style.

SVGs can be downloaded here. Figma file here.

@moeenio
Copy link

moeenio commented Nov 22, 2019

Great! #171 will give you help to submit it :)

@moeenio
Copy link

moeenio commented Nov 22, 2019

Believe we should rename it paint bucket though

@DawnPaladin
Copy link
Author

The contribution guidelines say:

Note: At the moment we are not accepting pull requests containing icons. The best way to contribute an icon is to create an issue with a screenshot and link to an SVG of your icon.

Should I create a PR anyway?

@moeenio
Copy link

moeenio commented Dec 3, 2019

This was updated Jul 2018, but do how you want

@DawnPaladin DawnPaladin linked a pull request Dec 17, 2019 that will close this issue
@MarcelloTheArcane
Copy link
Contributor

What about (2), but with a 2px gap between the paint drip as per the style guidelines?

@moeenio
Copy link

moeenio commented Jan 8, 2020

I don't think this would look very nice, but let's try

@DawnPaladin
Copy link
Author

image

Something like this?

@moeenio
Copy link

moeenio commented Feb 22, 2020

I'm not sure it really looks feather-ish @DawnPaladin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants