Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lasso or box select #943

Open
llaenowyd opened this issue Jun 26, 2020 · 8 comments
Open

lasso or box select #943

llaenowyd opened this issue Jun 26, 2020 · 8 comments

Comments

@llaenowyd
Copy link

Icon Request

  • Icon name: select (lasso, box)
  • Use case: I noticed there is a crop icon. I always want to box select before crop. I can't be the only one
  • Screenshots of similar icons:

select_icons
blender_menu
ancient_photoshop_select_icons
gimp_with_box_and_lasso_selects

@llaenowyd
Copy link
Author

🦗 I infer that I am in fact the only one.

@moeenio
Copy link

moeenio commented Jul 7, 2020

You aren't but it takes time for an issue to be considered.

@mishkaio
Copy link

box and lasso feather preview

feather-box-lasso.zip

I'm not 100% certain that these satisfy the design guidelines requirement about optical volumes but the lasso having the dangling bit really restricts the height of the main loop. I also don't know the right way to add these but I thought replying to the request thread was a good start.

@moeenio
Copy link

moeenio commented Jul 21, 2020

You can make a pull request here, but it might not get merged soon. You could submit it at @featherity .

@llaenowyd
Copy link
Author

bump - @mishkaio could you submit a PR with those icons, or link to it if you have?

@mishkaio
Copy link

@llaenowyd yes, I can attempt to do that. At this risk of sounding ridiculous, I never have before but I want to be involved so I need to figure it out...

@mishkaio
Copy link

@llaenowyd I bugged a kind dev coworker to get enough info to do this, hopefully this is what you needed.
https://github.com/featherity/featherity/pull/57

@llaenowyd
Copy link
Author

above link broken, should be lucide-icons/lucide#57
(link text is correct but markdown mixed up)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants