Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case Consistency #95

Open
Aparaxium opened this issue Sep 17, 2021 · 1 comment
Open

Case Consistency #95

Aparaxium opened this issue Sep 17, 2021 · 1 comment

Comments

@Aparaxium
Copy link

Aparaxium commented Sep 17, 2021

Is there a reason GitHub uses PascalCase while Gitlab uses Snakecase?

export { default as GitHub } from './icons/github';
export { default as Gitlab } from './icons/gitlab';

Proposal:
Change Gitlab to GitLab

@imMatheus
Copy link

I would maybe agree here, I first thought that it could be because GitLab spelled there name "Gitlab", in which case it makes sense to as it is now, but they dont. So this would make change to change. But also a super small thing that might have unnecessary ripple effects through out some peoples project, it is a braking change after all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants