Wrong measure text field width in BitmapFontTextRenderer

[Yaniko]

There is an error in measuring white space after a symbol. Current code is like (previousCharData.xAdvance - previousCharData.width) * scale;
Lines
https://github.com/BowlerHatLLC/feathers/blob/master/source/feathers/controls/text/BitmapFontTextRenderer.as#L806
https://github.com/BowlerHatLLC/feathers/blob/master/source/feathers/controls/text/BitmapFontTextRenderer.as#L833
and others.

The right formulae is xAdvance - width - xOffset, because char.width doesn't contain xOffset.
xAdvance = xOffset + width + someSpaceAfter
Because of that issue some chars (like colon) get cropped from the right in a textfield with TextAlign.RIGHT

[joshtynjala]

Thanks, I'll take a look soon!

[joshtynjala]

Switching to xAdvance - width - xOffset doesn't seem to work in some cases. According to another user who has tried the new code, this change causes BitmapFontTextRenderer to begin truncating text where it hadn't previously. Since that's not good at all, I have reverted this commit for now.

Unfortunately, the bitmap fonts that I've tested with cannot reproduce your issue, and I could not reproduce the new issue either. I guess it depends on the exact bitmap font that you use.

[Yaniko]

We use fonts with shadows generated in literra.
Extra truncating means text size become wider. And that means xOffset is negative? Really strange.

[Yaniko]

Sorry, I was wrong in my last message.
Of course strings become wider, because we subtract some positive value from whitespace. It makes sense.
Have you tried textalign.Right?

[joshtynjala]

No, I have not been able to reproduce with text aligned to the right either.

[divlaine]

a few days ago i tried textalign.Right on a label with backgroundskin and saw the text was out from label's borders. i can try to reproduce it and make screenshots if you want