New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[handle-later] do not decode envSecret every time when getting feature flag #13

Open

deleteLater opened this issue Sep 16, 2022 · 0 comments

Assignees

Labels

Member

deleteLater commented Sep 16, 2022

ffc-go-sdk/ffc/ffc_client.go

Lines 406 to 408 in f0961dd

    
           func (c *Client) getFlagInternal(featureFlagKey string) data.FeatureFlag { 
        
           	flagId := data.NewFeatureFlagIdByEnvSecret(c.EnvSecret, featureFlagKey).GetFeatureFlagId() 
        
           	item := c.dataStorage.Get(data.FeaturesCat, flagId)

every time we get feature flag from dataStorage, we have to decode the envSecret, which is unreasonable.

deleteLater added the enhancement label

deleteLater assigned bradzhang717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment