Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace layouting engine #3

Open
fechan opened this issue Apr 15, 2024 · 2 comments
Open

Replace layouting engine #3

fechan opened this issue Apr 15, 2024 · 2 comments
Labels
editor enhancement New feature or request

Comments

@fechan
Copy link
Owner

fechan commented Apr 15, 2024

Right now the layouting is really bad. Maybe it's best to use one of the layouting tools on the React Flow site.

Also the x,y positions of nodes should be saved after layout changes.
@fechan fechan added the enhancement New feature or request label Apr 15, 2024
@fechan fechan added this to the 1.0 milestone Apr 15, 2024
@fechan fechan added the editor label Apr 15, 2024
@fechan
Copy link
Owner Author

fechan commented May 6, 2024

Layouting has been added, but maybe the layout should be saved to each node instead of re-layouting everything every time nodes are added/removed...

@fechan
Copy link
Owner Author

fechan commented Jun 14, 2024

Ok I did a bunch of stuff to get around the layouting jank.

At this point I think ELK should be replaced with another layouting engine, or possibly we hand-roll a really simple one, because I don't think it's worth doubling the size of the editor app just to include ELK.

@fechan fechan changed the title Add layouting to editor Replace layouting engine Jun 14, 2024
@fechan fechan removed this from the 1.0 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fechan