-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fedimint Kotlin Wrapper #35
base: master
Are you sure you want to change the base?
Conversation
think you didn't commit the code for it, just has a markdown change |
@Kodylow This is ready for review. |
Can you add the tests and a test-kotlin command to the justfile.local.just like I have for the other wrappers?
Then there's a lot of printlns you should remove before merge |
Hey @Kodylow |
this fails in the nix environment, you have to add a java installation into the flake.nix and make sure this can run inside it here's a reference from another java project's flake.nix, looks like it just needs gradle and the jdk in the devShell's packages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits, will have a bigger review after you add the java stuff to the nix flake so I can test it
wrappers/fedimint-kotlin/src/main/kotlin/com/cashu/Application.kt
Outdated
Show resolved
Hide resolved
wrappers/fedimint-kotlin/src/main/kotlin/com/cashu/models/Lightning.kt
Outdated
Show resolved
Hide resolved
wrappers/fedimint-kotlin/src/test/kotlin/com/cashu/ApplicationTest.kt
Outdated
Show resolved
Hide resolved
Hey @Kodylow Fixed the nits too. |
This is a new kotlin implementation of a fedimint wrapper.
Resolves #33