Update rust-bitcoin

[jkitman]

It's one of our main crypto libs we are a few versions behind.

edit (justinmoon): edited this to be "update rust-bitcoin" from "update secp256k1"

[elsirion]

This will have to happen in lock step with rust-bitcoin, miniscript, all the BTC clients using rust-bitcoin structs (bitcoind, esplora, electrum) and possibly some other crates. We need to make sure that all required ones support the same secp version.

EDIT: I don't consider this necessary for alpha btw, it's probably mostly API changes, I doubt any serialization changed. One thing that migth be relevant for alpha: MuSig2 with normal compressed instead of x-only public keys #1458.

[elsirion]

This will likely be part of #2667.

[m1sterc001guy]

This is also blocked on the lightning and lightning-invoice crates. They do not support bitcoin 0.30.1 or secp256k1 0.27.0 yet.

https://crates.io/crates/lightning/0.0.116/dependencies
https://crates.io/crates/lightning-invoice/0.24.0/dependencies

[benthecarman]

Latest LDK release is now on 0.30

https://github.com/lightningdevkit/rust-lightning/releases/tag/v0.0.119

[EthnTuttle]

Latest LDK release is now on 0.30

https://github.com/lightningdevkit/rust-lightning/releases/tag/v0.0.119

lightningdevkit/rust-lightning#2799

[justinmoon]

lightningdevkit/rust-lightning#2799

If this is the only regression, I think we can still integrate because the only part of LDK that currently runs in WASM is lightning_invoice and the regression this PR fixes is elsewhere.

I propose we update on master but don't backport it.

[tvolk131]

If no one's currently working on this, I can give it a shot!

[m1sterc001guy]

I have a broken branch attempting to do this here: https://github.com/m1sterc001guy/fedimint/tree/update_rust_bitcoin

These updates touch a lot of files and some structs in rust-bitcoin removed their Encodable and Decodable traits.

[justinmoon]

Relevant TODO

fedimint/fedimint-core/src/session_outcome.rs

Lines 70 to 78 in 47eb296

	// TODO: remove this as soon as we bump bitcoin_hashes in fedimint_core to
	// 0.12.0
	pub fn consensus_hash_sha256<E: Encodable>(encodable: &E) -> sha256::Hash {
	let mut engine = sha256::HashEngine::default();
	encodable
	.consensus_encode(&mut engine)
	.expect("Writing to HashEngine cannot fail");
	sha256::Hash::from_engine(engine)
	}

[tvolk131]

Unless anyone knows of more work to do for this issue, I think we can mark this as done!

[m1sterc001guy]

@tvolk131 is going to make a separate issue for removing bitcoin 29 from the codebase.

[benthecarman]

congrats!