Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groups info through OIDC #2788

Open
pkking opened this issue Jun 26, 2023 · 4 comments · Fixed by #2836
Open

Support groups info through OIDC #2788

pkking opened this issue Jun 26, 2023 · 4 comments · Fixed by #2836
Assignees

Comments

@pkking
Copy link
Contributor

pkking commented Jun 26, 2023

As we have a basic support for OIDC, there's another feature we need so that we do not lost any functions when switching to OIDC.
Copr should have ability to fetch user's group info from Idp.

As group info is not covered by OIDC spec, but most of OIDC providers(etc google/auth0) support custom claim

I also talk to openEuler infra team, they can add the a group scope in the OIDC provider but i have no idea what fedora OIDC provider can do.

So here's my idea: add a config item: OIDC_type(such as: google/openEuler/fedora. etc), for each type, we can have a specified impl to grab the group info

Now i'd like hear from you and what you say about this proposal :)

@FrostyX FrostyX self-assigned this Jun 29, 2023
@praiskup
Copy link
Member

@FrostyX has took a look on what group support in Fedora OIDC, and so far no success, work in progress.

@pkking
Copy link
Contributor Author

pkking commented Jul 25, 2023

Hi, @FrostyX @praiskup , we have some experience on OIDC group info before because we try to get it into our jenkins cluster, in jenkins story, our OIDC userinfo endpoint will return a list of groups if a group scope is provided such as:

{
  "sub": "user123",
  "name": "John Doe",
  "email": "[email protected]",
  "groups": [
    "dev-utils",
    "eBPF",
    "kernel"
  ]
}

Im trying to find a way to let authlib to work in this way :)

@pkking
Copy link
Contributor Author

pkking commented Jul 25, 2023

seems lepture/authlib#549 will works like a charm

@pkking
Copy link
Contributor Author

pkking commented Aug 21, 2023

I think we should wait Fedora guys to finish their OIDC adaptation, the #2836 works well in openEuler now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Someday in future
Development

Successfully merging a pull request may close this issue.

3 participants