-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we support multi group alias for one group or not? #2825
Comments
There's just 1:1 mapping, and copr/frontend/coprs_frontend/coprs/models.py Line 2210 in 7442ec4
|
Otherwise, the |
When i was developing group supported in OIDC, i found some wired hehavior in group activated in fedora-copr#2825, So i submitted this PR, and @praiskup also give advice a TODO so i include the fix as well This PR try to fix: fedora-copr#2825 1. add unique contraint to fas_name and add migration script generated by alembic revision --autogenerate 2. I think macro fas_group_href canbe replaced by config.GROUP_INFO.link.forma which is more configurable 3. When creating a new alias for a group, if the group already has one alias, popup a flash and redirect to the already existed group Signed-off-by: Li Chaoran <[email protected]>
When i was developing group supported in OIDC, i found some wired hehavior in group activated in fedora-copr#2825, So i submitted this PR, and @praiskup also give advice a TODO so i include the fix as well This PR try to fix: fedora-copr#2825 1. add unique contraint to fas_name and add migration script generated by alembic revision --autogenerate 2. I think macro fas_group_href canbe replaced by config.GROUP_INFO.link.forma which is more configurable 3. When creating a new alias for a group, if the group already has one alias, popup a flash and redirect to the already existed group Signed-off-by: Li Chaoran <[email protected]>
When i was developing group supported in OIDC, i found some wired hehavior in group activated in fedora-copr#2825, So i submitted this PR, and @praiskup also give advice a TODO so i include the fix as well This PR try to fix: fedora-copr#2825 1. add unique contraint to fas_name and add migration script generated by alembic revision --autogenerate 2. I think macro fas_group_href canbe replaced by config.GROUP_INFO.link.forma which is more configurable 3. When creating a new alias for a group, if the group already has one alias, popup a flash and redirect to the already existed group Signed-off-by: Li Chaoran <[email protected]>
When i was developing group supported in OIDC, i found some wired hehavior in group activated in fedora-copr#2825, So i submitted this PR, and @praiskup also give advice a TODO so i include the fix as well This PR try to fix: fedora-copr#2825 1. add unique contraint to fas_name and add migration script generated by alembic revision --autogenerate 2. I think macro fas_group_href canbe replaced by config.GROUP_INFO.link.forma which is more configurable 3. When creating a new alias for a group, if the group already has one alias, popup a flash and redirect to the already existed group Signed-off-by: Li Chaoran <[email protected]>
When i was developing group supported in OIDC, i found some wired hehavior in group activated in fedora-copr#2825, So i submitted this PR, and @praiskup also give advice a TODO so i include the fix as well This PR try to fix: fedora-copr#2825 1. add unique contraint to fas_name and add migration script generated by alembic revision --autogenerate 2. I think macro fas_group_href canbe replaced by config.GROUP_INFO.link.forma which is more configurable 3. When creating a new alias for a group, if the group already has one alias, popup a flash and redirect to the already existed group Signed-off-by: Li Chaoran <[email protected]>
When i was developing group supported in OIDC, i found some wired hehavior in group activated in fedora-copr#2825, So i submitted this PR, and @praiskup also give advice a TODO so i include the fix as well This PR try to fix: fedora-copr#2825 1. add unique contraint to fas_name and add migration script generated by alembic revision --autogenerate 2. I think macro fas_group_href canbe replaced by config.GROUP_INFO.link.forma which is more configurable 3. When creating a new alias for a group, if the group already has one alias, popup a flash and redirect to the already existed group Signed-off-by: Li Chaoran <[email protected]>
When i was developing group supported in OIDC, i found some wired hehavior in group activated in fedora-copr#2825, So i submitted this PR, and @praiskup also give advice a TODO so i include the fix as well This PR try to fix: fedora-copr#2825 1. add unique contraint to fas_name and add migration script generated by alembic revision --autogenerate 2. I think macro fas_group_href canbe replaced by config.GROUP_INFO.link.forma which is more configurable 3. When creating a new alias for a group, if the group already has one alias, popup a flash and redirect to the already existed group Signed-off-by: Li Chaoran <[email protected]>
When i was developing group supported in OIDC, i found some wired hehavior in group activated in fedora-copr#2825, So i submitted this PR, and @praiskup also give advice a TODO so i include the fix as well This PR try to fix: fedora-copr#2825 1. add unique contraint to fas_name and add migration script generated by alembic revision --autogenerate 2. I think macro fas_group_href canbe replaced by config.GROUP_INFO.link.forma which is more configurable 3. When creating a new alias for a group, if the group already has one alias, popup a flash and redirect to the already existed group Signed-off-by: Li Chaoran <[email protected]>
Opened the issue because im confused by these code:
The code above will allow user submit more than one alias for a group, but if the group already has a alias, it just will always return it instead of create another alias, so the code behave is wired:
get_group_by_fas_name_and_alias_or_create
to both match the alias and group namegroup.name
instead ofalias
The text was updated successfully, but these errors were encountered: