Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom source timeout? #3384

Closed
qoijjj opened this issue Aug 23, 2024 · 5 comments · Fixed by #3404
Closed

Custom source timeout? #3384

qoijjj opened this issue Aug 23, 2024 · 5 comments · Fixed by #3404
Assignees

Comments

@qoijjj
Copy link

qoijjj commented Aug 23, 2024

For @secureblue/hardened-chromium, the source extraction and cleaning for the underlying chromium takes between 58 minutes and 62 minutes on the COPR source builder.

Since the source build timeout is 60 minutes, this means that 1 out of every 3 or 4 source builds gets timed out. Is there any way we can increase this to say 90 minutes? I see there's a field for build timeout customization, but not for source timeout.

Making this change would result in less copr builder usage by @secureblue/hardened-chromium since we wouldn't need to retry those timed-out builds.

@FrostyX
Copy link
Member

FrostyX commented Aug 24, 2024

Thank you for the report @qoijjj,

Is there any way we can increase this to say 90 minutes?

I don't think there is any.

I would go the easiest route and globally increase the limit from 60 minutes to 90 minutes instead of implementing a SRPM build timeout option. We will discuss it on a Monday meeting.

@qoijjj
Copy link
Author

qoijjj commented Sep 3, 2024

@FrostyX That would be great. What was the verdict from the meeting?

@FrostyX
Copy link
Member

FrostyX commented Sep 4, 2024

The verdict was, that we are going to increase the timeout to 90 minutes since that's the simplest solution for all of us.
I'll take a look at it this week.

@FrostyX
Copy link
Member

FrostyX commented Sep 6, 2024

@qoijjj the PR with the fix was merged but you'll need to wait until it gets to production. The new release wasn't scheduled yet, so it will take something from two weeks to a month.

Since it is a trivial fix, I'd hotfix it in production so that you would have it there instantly but unfortunately, the change was in a component that is hard to hotfix, and a proper release is required.

@qoijjj
Copy link
Author

qoijjj commented Sep 6, 2024

@FrostyX no problem, thanks for increasing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants