From 7fd02ab66987dc7d2bbc7a0634d1ae3b30d70565 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Wed, 17 Apr 2024 15:39:39 -0700 Subject: [PATCH] Add news fragment for PR #5630 This covers all the changes from the commits together. It's rather long, but as short as I could make it... Signed-off-by: Adam Williamson --- news/PR5630.bic | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 news/PR5630.bic diff --git a/news/PR5630.bic b/news/PR5630.bic new file mode 100644 index 0000000000..b02932efe9 --- /dev/null +++ b/news/PR5630.bic @@ -0,0 +1,14 @@ +Bodhi's update status checking has been overhauled, and some configuration options have changed. + +* critpath.num_admin_approvals is removed. This backed the old Fedora "proven testers" concept, which has not been used for some years. +* critpath.min_karma is removed and is replaced by a new setting just called min_karma. This applies to all updates, not just critical path. +* critpath.stable_after_days_without_negative_karma is renamed to critpath.mandatory_days_in_testing and its behavior has changed: there is no longer any check for 'no negative karma'. Critical path updates, like non-critical path updates, can now be manually pushed stable after reaching this time threshold even if they have negative karma. + +As before, these settings can be specified with prefixes to apply only to particular releases and milestones. min_karma and (critpath.)mandatory_days_in_testing now act strictly and consistently as minimum requirements for stable push. Any update may be pushed stable once it reaches either of those thresholds (and passes gating requirements, if gating is enabled). The update's stable_karma value is no longer ever considered in determining whether it may be pushed stable. stable_karma and stable_days are only used as triggers for automatic stable pushes (but for an update to be automatically pushed it must *also* reach either min_karma or (critpath.)mandatory_days_in_testing). + +The most obvious practical result of this change for Fedora is that, during phases where the policy minimum karma requirement is +2, you will no longer be able to make non-critical path updates pushable with +1 karma by setting this as their stable_karma value. Additionally: + +* It is no longer possible to set an update's request to 'stable' if it has previously met requirements but currently does not +* Two cases where updates that reached their unstable_karma thresholds were not obsoleted are resolved +* Updates in 'pending' as well as 'testing' status have autopush disabled upon receiving any negative karma +* The 'date_approved' property of updates is more consistently set as the date the update first became eligible for stable push