fix: remove bootupd #152
fix: remove bootupd #152
Conversation
|
Attempting to workaround/fix - fedora-iot/iot-distro#58 |
| @@ -90,6 +90,9 @@ install -DpZm 0644 etc/greenboot/greenboot.conf %{buildroot}%{_sysconfdir}/%{nam | |||
| %systemd_post greenboot-grub2-set-success.service | |||
| %systemd_post greenboot-rpm-ostree-grub2-check-fallback.service | |||
| %systemd_post redboot-auto-reboot.service | |||
| if [ -d /usr/lib/bootupd/grub2-static/configs.d ]; then | |||
There was a problem hiding this comment.
Nope! This is not going to work.
There was a problem hiding this comment.
you can't move package files around in post scripts, it means for example the rpm won't verify properly for one, and it's also extremely prone to errors and interruptions. Also if someone does custom image it may well break.
There was a problem hiding this comment.
@nullr0ute do you have any suggestions for conditionalizing where the grub config lands as Sayan is trying to do?
There was a problem hiding this comment.
The general rule of thumb is that you shouldn't do it. I think we need to step back and look at the actual problem.
There was a problem hiding this comment.
So I applied a hard link instead of mv also added in %postun to remove the ln post remove.
There was a problem hiding this comment.
Is there a chance that /etc would be mounted on a different flesystem?
Is symlink better for what we're trying to do?
There was a problem hiding this comment.
Thats a good point, hardlink will have issue between different file systems, softlink didn't work so I plan on using cp as it may not have an integrity issue as pointed out by @nullr0ute
| @@ -142,7 +145,7 @@ install -DpZm 0644 etc/greenboot/greenboot.conf %{buildroot}%{_sysconfdir}/%{nam | |||
| %dir %{_prefix}/lib/%{name}/red.d | |||
| %{_exec_prefix}/lib/motd.d/boot-status | |||
| %{_tmpfilesdir}/greenboot-status-motd.conf | |||
| %{_prefix}/etc/grub.d/*.cfg | |||
| %{_sysconfdir}/grub.d/*.cfg | |||
There was a problem hiding this comment.
This is an unrelated fix, it should be in a different commit/PR.
There was a problem hiding this comment.
I think you saw comparison between two commits, which made it seem unrelated.
It changes the path from bootupd/static-config to grub.d:
https://github.com/fedora-iot/greenboot/pull/152/files#r1747377644
say-paul
force-pushed
the
remove_bootupd
branch
2 times, most recently
from
37908bf
to
bb79e03
Compare
greenboot.spec
Outdated
| @@ -119,6 +121,9 @@ install -DpZm 0644 etc/greenboot/greenboot.conf %{buildroot}%{_sysconfdir}/%{nam | |||
| %systemd_postun greenboot-grub2-set-counter.service | |||
| %systemd_postun greenboot-grub2-set-success.service | |||
| %systemd_postun greenboot-rpm-ostree-grub2-check-fallback.service | |||
| if [ -f /usr/lib/bootupd/grub2-static/configs.d/greenboot.cfg ]; then | |||
| rm /usr/lib/bootupd/grub2-static/configs.d/greenboot.cfg | |||
* Moved greenboot config to /etc/grub.d. * %post symlink greenboot.cfg to bootupd if present * %postun remove symlink from bootupd if present Signed-off-by: saypaul <[email protected]>
say-paul
force-pushed
the
remove_bootupd
branch
from
dfb4ff6
to
2b36530
Compare
moved greenboot.cfg to /etc/grub.d