Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on exit : offer to stopkernel if still connected #22

Open
fenugrec opened this issue Oct 18, 2022 · 1 comment
Open

on exit : offer to stopkernel if still connected #22

fenugrec opened this issue Oct 18, 2022 · 1 comment

Comments

@fenugrec
Copy link
Owner

it's easy to forget, and newbies panic and don't know what to do.
@fenugrec fenugrec changed the title on exit : offer to stopkernel if applicable on exit : offer to stopkernel if still connected Oct 18, 2022
fenugrec added a commit that referenced this issue Nov 1, 2022
@fenugrec
on disconnect : offer to stop kernel
aa120a7 
Partial fix for GH #22 ; the 'quit' command still bypasses everything
@fenugrec
Copy link
Owner Author

fenugrec commented Nov 1, 2022

For a full fix, cmd_exit should be hooked or replaced within np_cli (instead of freediag/scantool_cli) to prompt for disconnection / kernel reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fenugrec