Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(breaking): use crc16 for writeblock command instead of cks_add8 #5

Open
fenugrec opened this issue May 31, 2021 · 0 comments
Open

(breaking): use crc16 for writeblock command instead of cks_add8 #5

fenugrec opened this issue May 31, 2021 · 0 comments
Labels
enhancement

Comments

@fenugrec
Copy link
Owner

cks_add8() is dumb and only used for <SID_FLASH> <SIDFL_WB> ... <CRC> frames. Using the crc16 code we already have anyway would eliminate some code, at the cost of 1 more byte to transfer per chunk.
This change would need to be done in nisprog at the same time. ( fenugrec/nisprog#12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fenugrec