You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the past when using $rollout.activate from the console there'd be a string response "OK"
After updating to rollout 2.5.0 my team-mates and I noticed that the activate method is returning false though it appears to be succeeding in activating the feature.
Wondering if this is intended behavior or some leakage from the save or notify_observers methods?
The text was updated successfully, but these errors were encountered:
@etherbob Good catch. Yes, it's intended behaviour change.
@reneklacan would you say a little more about the reasoning behind the change? I was trying to find a ticket or changelog entry so I could understand it and share with some colleagues.
@reneklacan specifically the confusion for us is that having #activate return false at the console level seems to indicate failure. If that's intentional it'd be great to have some docs that say what false is meant to imply.
In the past when using
$rollout.activate
from the console there'd be a string response "OK"After updating to rollout 2.5.0 my team-mates and I noticed that the activate method is returning false though it appears to be succeeding in activating the feature.
Wondering if this is intended behavior or some leakage from the save or notify_observers methods?
The text was updated successfully, but these errors were encountered: