From 8562a3fd0ea7b74c17892765688bd974e2b5c7b0 Mon Sep 17 00:00:00 2001 From: Felix Wiedenbach Date: Tue, 13 Feb 2024 22:57:44 +0100 Subject: [PATCH] Removes dependency node-fetch --- CHANGELOG.md | 6 +++++- README.md | 2 -- node_helper.js | 7 ------- package.json | 3 --- 4 files changed, 5 insertions(+), 13 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a43fdb7..95e7037 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,9 +2,11 @@ ## [Unreleased] +**Requires version >= 18 of NodeJS!** + ### Fixed -- [Switching to v4 due to empty tables in v2 of the API](https://github.com/fewieden/MMM-soccer/issues/70) +* [Switching to v4 due to empty tables in v2 of the API](https://github.com/fewieden/MMM-soccer/issues/70) ### Added @@ -12,6 +14,8 @@ ### Removed +* Dependency [node-fetch](https://www.npmjs.com/package/node-fetch) + ## [2.2.1] ### Fixed diff --git a/README.md b/README.md index 42f9c7f..a963f3a 100644 --- a/README.md +++ b/README.md @@ -10,8 +10,6 @@ European Soccer Standings Module for MagicMirror² * An installation of [MagicMirror²](https://github.com/MichMich/MagicMirror) * OPTIONAL: [Voice Control](https://github.com/fewieden/MMM-voice) and [MMM-Modal](https://github.com/fewieden/MMM-Modal) -* npm -* [node-fetch](https://www.npmjs.com/package/node-fetch) ## Installation diff --git a/node_helper.js b/node_helper.js index 6ccb5f6..8635e7c 100644 --- a/node_helper.js +++ b/node_helper.js @@ -10,12 +10,6 @@ /* eslint-env node */ /* eslint-disable no-console */ -/** - * @external node-fetch - * @see https://www.npmjs.com/package/node-fetch - */ -const fetch = require('node-fetch'); - /** * @external node_helper * @see https://github.com/MichMich/MagicMirror/blob/master/modules/node_modules/node_helper/index.js @@ -26,7 +20,6 @@ const NodeHelper = require('node_helper'); * @module node_helper * @description Backend for the module to query data from the API provider. * - * @requires external:node-fetch * @requires external:node_helper */ module.exports = NodeHelper.create({ diff --git a/package.json b/package.json index 497624a..067759e 100644 --- a/package.json +++ b/package.json @@ -31,9 +31,6 @@ "test": "jest", "test:coverage": "jest --coverage" }, - "dependencies": { - "node-fetch": "^2.6.1" - }, "devDependencies": { "eslint": "^6.8.0", "eslint-config-recommended": "^4.1.0",