Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a custom domain as a tunnel parameter #63

Open
peterwurzinger opened this issue Jul 9, 2024 · 0 comments
Open

Accept a custom domain as a tunnel parameter #63

peterwurzinger opened this issue Jul 9, 2024 · 0 comments

Comments

@peterwurzinger
Copy link

peterwurzinger commented Jul 9, 2024

Hi,
First of all, thanks for your work! :)

Currently it's not possible to pass a custom domain to a created tunnel. When testing applications that need to process webhooks, those webhook endpoints are normally passed as static URIs.

It should not be that hard to implement that requirement, some quick tests according to the docs would indicate, that it's only a matter of passing a domain property in here. Since the API client already holds a options instance, it would make sense to extend those by string? Domain.
Since it's a optional value anyway, it wouldn't lead to a breaking change.

Would you accept a PR?

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant