Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NodeSelectors #139

Open
edupedup opened this issue Feb 5, 2021 · 4 comments
Open

Support NodeSelectors #139

edupedup opened this issue Feb 5, 2021 · 4 comments
Assignees

Comments

@edupedup
Copy link

edupedup commented Feb 5, 2021

We are using fiaas to deploy our API and It does the job, but now we also would like to deploy different types of applications like streaming, ML or batch applications that require pods to be scheduled on specific nodes. Taints are not sufficient as it does not restrics API pods to be scheduled on those nodes.
Therefor we would like to be able to add nodeSelectors to our pods.

The idea would be to add to the spec file a field like :

  nodeSelector:
    disktype: ssd

We would really like to have this feature, wdyt ?

@gregjones
Copy link
Contributor

It sounds good to me. Do you think you'll be able to work on this?

@xavileon
Copy link
Contributor

xavileon commented Jul 5, 2022

@fiaas/maintainers we may start working on this feature in the close future. It would basically mean adding nodeSelector matching by node label to the FIAAS spec as done in the issue description. The interface seems quite simple and clear for the user.

Is there any concern in adding this feature that we didn't consider?

@bjornakr
Copy link
Contributor

We discussed this in the FIAAS maintainers team, and it looks good to us. Feel free to move forward with this.

@portega-adv
Copy link
Contributor

Thanks @bjornakr, I'll talk with the team to schedule the implementation. We'll keep you updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants