Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter to limit the number of subdomains when TLS is enabled #239

Open
herodes1991 opened this issue Apr 11, 2024 · 1 comment
Open

Comments

@herodes1991
Copy link
Contributor

herodes1991 commented Apr 11, 2024

Recently our ACME provider add a limit for the number of subdomains a certificate can have.

Keeping in mind that this is a typical thing in the ACME providers, can we include a parameter to actually limit the number of subdomains a TLS Ingress can have in the host? Something like --limit-of-subdomains-per-tls=N and prevent the IngressDeployer to fail-fast without modifying the actual Ingresses.

WDYT? Did it make sense guys? @fiaas/maintainers

@oyvindio
Copy link
Member

I'm not sure if it makes sense, but could it be an option to enforce such a limit even before the Application resource is created?

How would deployment of an application where limit-of-subdomains-per-tls is exceeded be handled? Update all other resources (which could in some cases include other ingresses) and then fail the deployment before updating the offending ingress?

I don't have a strong opinion against adding the feature as such, so if it is not possible to do "on the outside" I suppose it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants