You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
It gets fixed with the following patch, i.e. if we set Config.PrivateKey to the raw (encoded) string. ajx42@f10c434
A related problem is the following, which the above patch also fixes: showPublicKey is passing the already decoded key to getPubKey: https://github.com/fiatjaf/noscl/blob/master/key.go#L55
There is this older PR that fixes this issue at another place #50
Currently we get this:
I can go ahead and fix it if it's okay. Feel free to assign me. I am trying to learn about this codebase, so happy to help.
The text was updated successfully, but these errors were encountered:
ajx42
changed the title
Bug in noscl showPublicKey
Bug in Private Key Encoding/Decoding handling
Apr 19, 2023
It seems the following (pool.SecretKey) expects an encoded key string. Currently, we are decoding the key string before setting it here.
https://github.com/fiatjaf/noscl/blob/master/nostr.go#L40-L42
It gets fixed with the following patch, i.e. if we set
Config.PrivateKey
to the raw (encoded) string.ajx42@f10c434
A related problem is the following, which the above patch also fixes:
showPublicKey
is passing the already decoded key to getPubKey: https://github.com/fiatjaf/noscl/blob/master/key.go#L55There is this older PR that fixes this issue at another place #50
Currently we get this:
I can go ahead and fix it if it's okay. Feel free to assign me. I am trying to learn about this codebase, so happy to help.
The text was updated successfully, but these errors were encountered: