Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java API Wrapper for the Skycoin node #15

Open
10 tasks done
stdevMac opened this issue Mar 13, 2019 · 1 comment
Open
10 tasks done

Java API Wrapper for the Skycoin node #15

stdevMac opened this issue Mar 13, 2019 · 1 comment
Assignees
@stdevMac
Milestone
0.27.0

Comments

@stdevMac
Copy link
Member

stdevMac commented Mar 13, 2019 •
edited
Loading

Expected Behavior

Access to the Skycoin node REST API implemented in Java code or as .jar assembly

Actual Behavior

Right now this is only possible using code generated by SWIG , which requires memory handles

Specifications

  • Version: 0.25.1
  • Platform: all
  • Subsystem: all exported API sets

Possible Solution

Generate with Swagger (share more info, please) . Beware of CSRF .

  • Use Skycoin node Swagger spec to generate initial Java REST API client
  • Add make target to automate generation in ./build
  • Aforementioned target should copy / merge relevant files into source code tree
  • README explaining the process
  • Mention in CHANGELOG
  • Patch the result Swagger-gen REST client to support specifying node address
  • Update package metadata
  • Run basic Swagger tests in Travis
  • Unify testing code if multiple frameworks are used across source tree
  • Beware of CSRF auth
@stdevMac stdevMac self-assigned this Mar 13, 2019
stdevMac added a commit that referenced this issue Mar 15, 2019
@stdevMac
[skyapi] refs #15 Added wrapper autogenerated
052a293
stdevMac added a commit that referenced this issue Mar 15, 2019
@stdevMac
[skyapi] refs #15 Remove oraclejdk7 from travis
8640f95
stdevMac added a commit that referenced this issue Mar 15, 2019
@stdevMac
[skyapi] refs #15 Update Makefile and fix error in code autogenerated
bb18070
@stdevMac stdevMac mentioned this issue Mar 15, 2019
Closed
stdevMac added a commit that referenced this issue Mar 19, 2019
@stdevMac
[readme] refs #15 #17 Added README.md for libjava
96d68db
stdevMac added a commit that referenced this issue Mar 19, 2019
@stdevMac
[skyapi] refs #15 Added in readme hot to change host and added Changelog
704a3a1
@olemis olemis added this to the 0.25.1 milestone Apr 21, 2019
stdevMac added a commit that referenced this issue Apr 21, 2019
@stdevMac
[skyapi] refs #15 Removed README.md
6b4ccf2
@stdevMac
Copy link
Member Author

Update skyapi to latest swagger spec, can be found here => https://github.com/simelo/libskycoin/blob/stdevMac_t3_v0.25.1_C_Wrapper_Skycoin_Api/lib/swagger/skycoin.v0.25.1.openapi.v2.yml

stdevMac added a commit that referenced this issue Jun 6, 2019
@stdevMac
[skyapi] refs #15 Regenerate at 0.25.1 for change in spec
662490d
@m4yk3ldev m4yk3ldev modified the milestones: 0.25.1, 0.26.0 Jul 18, 2019
@m4yk3ldev m4yk3ldev modified the milestones: 0.26.0, 0.27.0 Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stdevMac stdevMac

Labels
None yet
Projects
None yet
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

FIxes #15 Wrapper Skycoin API in java fibercrypto/libjava-skyfiber
3 participants
@olemis @m4yk3ldev @stdevMac