Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passphrase not supported for signing transactions #250

Open
3 tasks
isaacvr opened this issue Oct 31, 2019 · 0 comments
Open
3 tasks

Passphrase not supported for signing transactions #250

isaacvr opened this issue Oct 31, 2019 · 0 comments
Labels
enhancement New feature or request firmware MCU firmware skycoin Skycoin messages stdev wip
Milestone

Comments

@isaacvr
Copy link
Contributor

isaacvr commented Oct 31, 2019

Feature description

Support passphrase for signin transactions

Is your feature request related to a problem? Please describe.
If passphrase is configured on device then Skywallet manages an address sequence different from using no passphrase at all . Transaction signing handler does neither seems to be aware of this nor even offers .

Describe the solution you'd like
Implement usePassphrase in msgTransactionSignImpl and fsm_msgTransactionSign

Describe alternatives you've considered
This has to be implemented for consistency with other functions.

Additional context
Needs similar issues in client libraries.

Possible implementation

  • Read device settings and use passphrase if option set
  • Add optional usePassphrase in message to force using (ignoring) passphrase if value set
  • If passphrase set derive master node from master seed prior to signing Skycoin transaction.
@isaacvr isaacvr added enhancement New feature or request firmware MCU firmware stdev wip labels Oct 31, 2019
isaacvr pushed a commit to simelo/skywallet-mcu that referenced this issue Oct 31, 2019
@olemis olemis added the skycoin Skycoin messages label Mar 4, 2020
@olemis olemis added this to the v2 milestone Mar 4, 2020
olemis added a commit to simelo/skywallet-mcu that referenced this issue Mar 4, 2020
…e stdevAdrianPaez_t63_edit_tx_messages_for_passphrase_option branch
@olemis olemis modified the milestones: v2, v3 Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request firmware MCU firmware skycoin Skycoin messages stdev wip
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants