Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device id does not match between bootloader mode screen and features message #253

Open
isaacvr opened this issue Oct 31, 2019 · 0 comments
Labels
bootloader MCU bootloader bug Something isn't working firmware MCU firmware help wanted Extra attention is needed question Further information is requested

Comments

@isaacvr
Copy link
Contributor

isaacvr commented Oct 31, 2019

Describe the bug
The features message return the device ID in hexadecimal

Environment information:

  • OS: GNU/Linux
  • Platform: Linux 4.19.0-1-amd64 x86_64
  • Firmware Version: a9e7d92

Steps to Reproduce
Steps to reproduce the behavior:

  1. Plug in the device.
  2. Hint a command to get features, eg: skycoin-hw-cli features
  3. Unplug the device.
  4. Plug in the device again but with the both buttons pressed.
  5. Look at the screen for the Serial No. value.

Actual behavior
From the features command the device returns the device id in hexadecimal, for the bootloader mode the screen show the hexadecimal of the hash of the device id.

Expected behavior
Need to be defined, but should match.

Additional context
This affect the desktop wallet as when you setup a device for the first time the device have the device id as label.

Screens:

skycoin-hw-cli features
{"vendor":"Skycoin Foundation","device_id":"353839350951373349002B00","pin_protection":false,"passphrase_protection":false,"initialized":true,"bootloader_hash":"jFmzRR/QBeL4vXfEDEhbewtnujIOjZ0FIbSGUvKPVNE=","pin_cached":false,"passphrase_cached":false,"needs_backup":true,"model":"1","fw_major":1,"fw_minor":7,"fw_patch":0,"firmware_features":0}
[2019-06-07T19:43:36-04:00] INFO [skycoin-hw-cli]: 

Firmware features:
{"RequireGetEntropyConfirm":false,"IsGetEntropyEnabled":false,"IsEmulator":false,"FirmwareFeaturesRdpLevel":0}

wallet-desktop

hw-bootloader

@isaacvr isaacvr added bootloader MCU bootloader bug Something isn't working firmware MCU firmware help wanted Extra attention is needed question Further information is requested labels Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootloader MCU bootloader bug Something isn't working firmware MCU firmware help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant