New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display rotation #370

Open

3 tasks

olemis opened this issue Nov 20, 2019 · 0 comments

Labels

firmware management

Milestone

Collaborator

olemis commented Nov 20, 2019 •

edited

Loading

Feature description

Describe the feature

Is your feature request related to a problem? Please describe.

People sometimes thinks that display rotation is a software bug.
Lock screen and PIN entry might not be affected by the rotation settings, which defeats its purpose for heads-down mounts.
Settings currently might not survive device restart.

Describe the solution you'd like
Implement display rotation

Additional context
Requires fibercrypto/skywallet-protob#76

Possible implementation

Make rotation as a device settings over ApplySettings() message as unprotected value (similar to background image & label).
Make PIN entry and lock screen compatible with rotation.
Check if rotation is possible over swipe gesture. If so disable it.

olemis added firmware management labels

olemis added this to the v3 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment