Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new field to transaction messages for passphrase option #63

Open
isaacvr opened this issue Oct 31, 2019 · 0 comments
Open

Add new field to transaction messages for passphrase option #63

isaacvr opened this issue Oct 31, 2019 · 0 comments

Comments

@isaacvr
Copy link

isaacvr commented Oct 31, 2019

Is your feature request related to a problem? Please describe.
For resolve issue https://github.com/skycoin/hardware-wallet/issues/250 I need modify the transaction messages.

Describe the solution you'd like
Add to transaction messages a new boolean field indicating if passphrase is used to signing transaction or not.

Describe alternatives you've considered
I don't see another solution

Additional context
Need for https://github.com/skycoin/hardware-wallet/issues/250
@isaacvr isaacvr mentioned this issue Oct 31, 2019
Closed
isaacvr pushed a commit to simelo/skywallet-protob that referenced this issue Oct 31, 2019
@adriantpaez
[messages] refs fibercrypto#63 - Ass usePassphrase option on Transact…
57d43ce 
…ionSign message
@isaacvr isaacvr mentioned this issue Oct 31, 2019
Closed
stdevAlDen pushed a commit to simelo/skywallet-protob that referenced this issue Nov 11, 2019
@olemis
Merge pull request fibercrypto#63 from simelo/stdevAlDen_t62_refactor…
9515edb 
…_API_to_make_it_more_testeable

Refactor api to make it more testeable - fixes fibercrypto#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #63 edit transaction messages for passphrase option simelo/skywallet-protob
1 participant
@isaacvr