Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context.py:440-441: Uncomment the if_404 check for empty... #189

Open
0pdd opened this issue Sep 22, 2018 · 1 comment
Open

context.py:440-441: Uncomment the if_404 check for empty... #189

0pdd opened this issue Sep 22, 2018 · 1 comment
Labels
3 we can defer this issue. But it'll good to implement it 30 mins small issues. Usually cosmetic fixes blocked issue is blocked by another issue cleanup everything that do project stronger, flexible, reusable Tags STB's feature take it any teammate can take this issue and start working with it

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 22, 2018

The puzzle 187-26ce6496 from #187 has to be resolved:

refarm-site/catalog/context.py

Lines 440 to 441 in 8d25b32

# @todo #187:30m Uncomment the if_404 check for empty products list.
# To do it fix stb tests to cover this case.

The puzzle was created by duker33 on 22-Sep-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Sep 22, 2018
@duker33
Stb187 tags feature (#187)
8d25b32 
* stb#187  Interface to implement stb side

* stb#187  Minor self-review fixes

* stb#187  Review#1 fix. Rm unused defaultdict
@0pdd 0pdd mentioned this issue Sep 22, 2018
Merged
@duker33 duker33 self-assigned this Sep 22, 2018
@duker33 duker33 added 30 mins small issues. Usually cosmetic fixes 2 performer can implement issue at his closest convenient time Tags STB's feature cleanup everything that do project stronger, flexible, reusable labels Sep 22, 2018
@duker33
Copy link
Collaborator

duker33 commented Nov 2, 2018

depends on fidals/stroyprombeton#328

@duker33 duker33 added blocked issue is blocked by another issue 3 we can defer this issue. But it'll good to implement it and removed 2 performer can implement issue at his closest convenient time labels Nov 2, 2018
@duker33 duker33 removed their assignment Nov 2, 2018
@duker33 duker33 added the take it any teammate can take this issue and start working with it label Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 we can defer this issue. But it'll good to implement it 30 mins small issues. Usually cosmetic fixes blocked issue is blocked by another issue cleanup everything that do project stronger, flexible, reusable Tags STB's feature take it any teammate can take this issue and start working with it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd