additional tests

Author: RafalMagrys

packages/application/src/patterns/decorators/signature-guard.decorator.test.ts

@@ -1,6 +1,6 @@
 import { afterEach, describe, expect, it, vi } from 'vitest';
 import type { Response } from 'express';
-import { SignatureGuard, SignatureType } from './signature-guard.decorator';
+import { messageFactoryByType, SignatureGuard, SignatureType } from './signature-guard.decorator';
 
 const mocks = vi.hoisted(() => ({
   mockVerifyLedgerPoP: vi.fn(),
@@ -101,3 +101,26 @@ describe('SignatureGuard', () => {
     expect(mocks.mockResponse.res.status).toHaveBeenCalledWith(400);
   });
 });
+
+describe('SignatureGuard messageFactoryByType', () => {
+  afterEach(() => {
+    vi.clearAllMocks();
+  });
+
+  const props = {
+    result: 'Approved',
+    id: '123',
+    finalDataCap: 1024,
+    allocatorType: 'RKH',
+  };
+
+  it.each`
+    signatureType                            | expectedMessage
+    ${SignatureType.RefreshReview}           | ${'Governance refresh Approved 123 1024 RKH'}
+    ${SignatureType.ApproveGovernanceReview} | ${'Governance Approved 123 1024 RKH'}
+    ${SignatureType.KycOverride}             | ${'KYC Override for 123'}
+    ${SignatureType.KycRevoke}               | ${'KYC Revoke for 123'}
+  `('returns the correct message for $signatureType', ({ signatureType, expectedMessage }) => {
+    expect(messageFactoryByType[signatureType](props)).toBe(expectedMessage);
+  });
+});

packages/application/src/patterns/decorators/signature-guard.decorator.ts

@@ -13,6 +13,7 @@ interface MessageFactoryProps {
 
 export enum SignatureType {
   RefreshReview = 'refreshReview',
+  ApproveGovernanceReview = 'approveGovernanceReview',
   KycOverride = 'kycOverride',
   KycRevoke = 'kycRevoke',
 }
@@ -23,6 +24,12 @@ export const messageFactoryByType = {
     id,
     finalDataCap,
     allocatorType,
+  }: MessageFactoryProps) => `Governance refresh ${result} ${id} ${finalDataCap} ${allocatorType}`,
+  [SignatureType.ApproveGovernanceReview]: ({
+    result,
+    id,
+    finalDataCap,
+    allocatorType,
   }: MessageFactoryProps) => `Governance ${result} ${id} ${finalDataCap} ${allocatorType}`,
   [SignatureType.KycOverride]: ({ id }: MessageFactoryProps) => `KYC Override for ${id}`,
   [SignatureType.KycRevoke]: ({ id }: MessageFactoryProps) => `KYC Revoke for ${id}`,