Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to prepend snippets with messaging? #196

Open
ericandrewscott opened this issue Oct 24, 2024 · 3 comments
Open

Is it possible to prepend snippets with messaging? #196

ericandrewscott opened this issue Oct 24, 2024 · 3 comments
Labels
feature request under discussion The Code Connect team is currently discussing this request

Comments

@ericandrewscott
Copy link

ericandrewscott commented Oct 24, 2024

So as we're connecting code for internal customers, it's still very much in an alpha phase for us internally until we:

  • plan a cross-discipline process for maintenance and accuracy
  • have capacity/knowledge for our design system support to be able to answer Code Connect questions
  • have a method to support bugs in our connected code for our internal support team
  • have a roadmap to scale Code Connect to include our native platforms (Swift and Kotlin)

Is there a way for us to add some sort of comment or message to the Code Connect snippets? Either in the code or outside? Added through the config? Without editing each individual connect statement? Through the custom imports (but hopefully without affecting the actual imports?

@tomduncalf-figma
Copy link
Contributor

Hey @ericandrewscott, right now we don't have any way to support this but it's an interesting idea, so I'll be sure to share it with the team!

@tomduncalf-figma tomduncalf-figma added the under discussion The Code Connect team is currently discussing this request label Oct 24, 2024
@ericandrewscott
Copy link
Author

ericandrewscott commented Oct 25, 2024

@tomduncalf-figma I think this would be super beneficial to all companies. I was chatting with Chris Hodges the other day and he said there are 600!!! enterprise Figma customers either onboarding or with POCs, so I would think as those are in progress (because things are either published or not, there's no test environment), having some sort of messaging to internal (or external) consumers might be super useful!

I know part of the reason we unpublished after our POC, which connected all components except 1, was because it was still very much a work in progress and in an internal alpha, as y'all are continuously introducing new features that are super useful to us, like recently being able to get instance props for icons! If we can communicate that alpha/experimental state, we'd feel confident leaving it out there and published internally!

@ericandrewscott
Copy link
Author

ericandrewscott commented Oct 25, 2024

FWIW, It's also worth mentioning that anecdotally, one of the results of us hooking up Code Connect as a POC was identifying huge opportunities for refactoring our design components. We're a pretty large company with many many brands and ~65 components and 4 different platforms (I don't know if I'm allowed to say which one, but you can sleuth it out from LinkedIn haha!) , and may of those opportunities were to adopt some of the newer features in Figma from the last few years, like:

  • Nested options under boolean properties
  • Text as a design prop instead of overriding on the node
  • Flattening our components by suppressing at publish and using the above prop features, removing subcomponents
  • Actually aligning props across platforms, shouldn't be hasError=true on one platform and isValid=false on another

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request under discussion The Code Connect team is currently discussing this request
Projects
None yet
Development

No branches or pull requests

2 participants