Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings for SlideNodes causing breaking changes #321

Open
labithiotis opened this issue Jan 15, 2025 · 1 comment
Open

Typings for SlideNodes causing breaking changes #321

labithiotis opened this issue Jan 15, 2025 · 1 comment

Comments

@labithiotis
Copy link

labithiotis commented Jan 15, 2025

Hey Figma team!

With the upcoming changes to plugin typings in version v1.107.0-beta.1, I noticed the introduction of several new node types: SlideNode, SlideRowNode, SlideGridNode, and InteractiveSlideElementNode, which have been added to the SceneNode type. This has resulted in a significant breaking change in our codebase, as we rely heavily on SceneNode. Currently, we're facing over 500+ errors due to the absence of common properties like x, y, width, and height which are not present on the slide-type nodes.

The situation is further complicated by the children of nodes that utilize SceneNode, making it challenging to simply define a custom type that omits slide nodes.

Would the development team consider separating these types to prevent this breaking changes?

For example:

type SceneNode = SliceNode | FrameNode ...etc;

type SceneNodeAndSlideNode =
  | SceneNode 
  | SlideNode
  | SlideRowNode
  | SlideGridNode
  | InteractiveSlideElementNode;

Thank you for your consideration!

@grace-figma
Copy link
Contributor

Ack! we'll look into it, thanks for flagging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants