Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce logging #23

Open
Tracked by #24
fijam opened this issue May 9, 2022 · 2 comments
Open
Tracked by #24

Introduce logging #23

fijam opened this issue May 9, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@fijam
Copy link
Owner

fijam commented May 9, 2022

Some of the messages printed are too verbose. Move some of them to a logging facility, and expose an argument to display them (or save to a log file).

Initial work in 5e36034

@fijam fijam added the enhancement New feature or request label May 9, 2022
@fijam fijam modified the milestones: v0.7, v0.8 May 9, 2022
@fijam
Copy link
Owner Author

fijam commented May 10, 2022

finishing this will require a bit of a refactor

@fijam fijam mentioned this issue May 10, 2022
2 tasks
@fijam
Copy link
Owner Author

fijam commented May 12, 2022

There is a bit of a chicken-egg problem... we are loading hardware before main() to avoid #4 and hardware imports logging, so we would need to do logging.basicConfig before that - which works, but isn't pretty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant