Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check integration test trace expectations related to deal publishing #1302

Open
2 tasks
anorth opened this issue May 23, 2023 · 0 comments
Open
2 tasks

Check integration test trace expectations related to deal publishing #1302

anorth opened this issue May 23, 2023 · 0 comments

Comments

@anorth
Copy link
Member

anorth commented May 23, 2023

Some complex calls related to deal publishing don't have trace expectations checked in integration tests. This means that some inner calls might not be working how we expect them, and we could fail to detect unexpected changes in behaviour caused by code change.

  • The DealBatcher doesn't check expectations when publishing
  • Deal activation isn't checked during prove commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant