Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACKING: Filsnap Updates #1

Closed
51 tasks done
hugomrdias opened this issue Jun 12, 2023 · 0 comments
Closed
51 tasks done

TRACKING: Filsnap Updates #1

hugomrdias opened this issue Jun 12, 2023 · 0 comments
Assignees

Comments

@hugomrdias
Copy link
Collaborator

hugomrdias commented Jun 12, 2023

Tasks

Developer tooling and experience improvements

Code Improvements

  • Zod schemas with validations and types for RPC messages and metamask state
  • RPC client for lotus using zod schemas
  • onRpcRequest should check if fil_configure was called already and build up a "context" for other methods with snap, config, api client, keypair etc avoiding multiple instances and async tasks to get snap state.
  • Remove dependency on @zondax/filecoin-signing-tools and Buffer
  • Swap all the validation in src/utils/params.ts for zod schemas
  • Check new snaps UI https://docs.metamask.io/snaps/reference/rpc-api/#snap_dialog and src/util/confirmation.ts
  • Add pnpm patch to snaps-cli/dist/utils/misc.js changing config file to snap.config.cjs
  • Write new RPC or use some other client like izari-filecoin
  • compress snap bundle https://github.com/terser/terser
  • flask now forces semver in the snap version option change metamask-testing-tools to account for that
  • tests need to have the snap version injected from the snap manifest
  • export private key MM popup needs rework
  • sign raw popup rework
  • send message popup rework

Metamask 10.28+ compatibility

  • Research metamask new flask/snap permissions system (caveats based) and plan changes needed in filsnap.
  • Update filsnap to the new permissions system
  • Document changes and how it works to make future changes easier. (metamask said it may change again multiples until 10.29.0/end of the year)
  • Unit and e2e tests for these changes.
  • Check snap config type and check if we need to refactor it and where all the properties are used.
  • Make sure the snap manifest gets updated and committed in the CI

Filsnap adapter

  • Merge Update adapter and demo #6
  • Make sure there are no breaking changes to the adapter API
  • Rework the demo
  • Publish demo
  • Check filsnap icons for the install snap popup
  • Publish new package to npm
  • e2e tests running against the demo app
  • Fix selection highlight in the demo app
  • deploy with npm:filsnap SNAP_ID

Support FEVM transactions

  • Research FVM/FEVM transactions, requirements, flows and tools.
  • Support send FIL to f410 addrs
  • Handle FEVM transactions (cbor encoded)
  • New unit and e2e tests for FEVM features
  • Update demo page with FEVM features
  • Collaborate with Glif to validate filsnap works as expected

Others

References

Notes

@hugomrdias hugomrdias pinned this issue Jun 12, 2023
@hugomrdias hugomrdias self-assigned this Jun 13, 2023
@hugomrdias hugomrdias changed the title Filsnap Updates Tracking TRACKING: Filsnap Updates Jun 13, 2023
@hugomrdias hugomrdias unpinned this issue Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant