Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP 0045 verified client claim extension #9466

Closed
6 of 15 tasks
ZenGround0 opened this issue Oct 11, 2022 · 6 comments
Closed
6 of 15 tasks

FIP 0045 verified client claim extension #9466

ZenGround0 opened this issue Oct 11, 2022 · 6 comments
Labels
kind/enhancement Kind: Enhancement P2 P2: Should be resolved
Milestone

Comments

@ZenGround0
Copy link
Contributor

Checklist

  • This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated improvement to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Improvement Suggestion

After nv17 builtin actors allows two different claim extension modes

  1. Free Extension. The client of the claim (verified deal client in current state of the world) can extend the claim up to five years from the original claim term start (epoch of ProveCommit). This works even if the claim is expired (claim term start + term max > current epoch)

  2. Paid Extension. Anyone who spends datacap can extend the claim up to five years from the current epoch. This does not work if the claim is expired.

Each probably warrants a cli command in the place where other verified client commands exist. Free Extension works by calling verifreg ExtendClaimTerms with straightforward params. Paid Extension works by actually calling DataCap actor Transfer method from a verified client with datacap to spend.

@jennijuju jennijuju added P2 P2: Should be resolved and removed need/triage labels Oct 11, 2022
@jennijuju jennijuju added this to the v1.19.0 milestone Oct 11, 2022
@jennijuju jennijuju moved this to Incoming in Network nv17 Oct 11, 2022
@jennijuju jennijuju moved this from Incoming to Opportunistic in Network nv17 Oct 11, 2022
@beck-8
Copy link
Contributor

beck-8 commented Mar 2, 2023

Related issues: #10001

@beck-8
Copy link
Contributor

beck-8 commented Mar 2, 2023

image
I see here that this method only allows the transfer of tokens between governors, and does not apply to clients and sps. Is it not supported by the current network version?

@rjan90
Copy link
Contributor

rjan90 commented Mar 3, 2023

I see here that this method only allows the transfer of tokens between governors, and does not apply to clients and sps. Is it not supported by the current network version?

That is correct! Transfers between clients are not allowed today, because it breaks FIL+ governance assumptions. A change here is a political / governance decision, not a technical one.

@beck-8
Copy link
Contributor

beck-8 commented Mar 3, 2023

Got it, now the second way (other client renewing the claim) is not supported.

@anorth
Copy link
Member

anorth commented Mar 7, 2023

The verified registry is the "governor" referred to in that comment. So transferring tokens to it (only) is supported.

@rjan90
Copy link
Contributor

rjan90 commented Apr 14, 2024

Closed by: #11711

@rjan90 rjan90 closed this as completed Apr 14, 2024
@github-project-automation github-project-automation bot moved this from Opportunistic to Done in Network nv17 Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Kind: Enhancement P2 P2: Should be resolved
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants