Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace final actor state #1995

Open
Stebalien opened this issue Feb 20, 2024 · 3 comments
Open

Trace final actor state #1995

Stebalien opened this issue Feb 20, 2024 · 3 comments

Comments

@Stebalien
Copy link
Member

At the moment, we trace the state of every invoked actor, but we don't include the state after it returns. For completeness, we should include the after state giving us:

  1. The remaining balance.
  2. The final state.
  3. Whether or not it selfdestructed.
@rjan90
Copy link
Contributor

rjan90 commented Apr 30, 2024

@aarshkshah1992 can we sync on this issue this week. I can talk with Eva if this is really needed by Blockscout, etc.

@rjan90 rjan90 removed the status in FilOz May 14, 2024
@rvagg
Copy link
Member

rvagg commented Jan 23, 2025

@Stebalien this is only with a tracing turned on, correct?

we trace the state of every invoked actor

This is with ExecutionEvent::InvokeActor, correct? So we'd introduce something like ExecutionEvent::ActorReturned which would include id, state and then a boolean for self-destruct? How would we determine that? Would we have to do a look-up on the actor to see if it still exists in the state at that point?

@Stebalien
Copy link
Member Author

@Stebalien this is only with a tracing turned on, correct?

Yes.

This is with ExecutionEvent::InvokeActor, correct? So we'd introduce
something like ExecutionEvent::ActorReturned...

Yes. (probably ExecutionEvent::ExitActor, but yeah)

which would include id, state and then a boolean for self-destruct?

We shouldn't have to include the ID because it should always be paired with an InvokeActor.

How would we determine that? Would we have to do a look-up on the actor to see if it still exists in the state at that point?

Yes. Although that'll be cached so the check should be fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants