Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a client side max retrieval duration timeout #99

Open
BigLep opened this issue Nov 1, 2024 · 1 comment
Open

Add a client side max retrieval duration timeout #99

BigLep opened this issue Nov 1, 2024 · 1 comment
Labels
good first issue 🤗 Good for newcomers

Comments

@BigLep
Copy link

BigLep commented Nov 1, 2024

This is coming out of timeout discussion in https://www.notion.so/protocollabs/Spark-Request-Based-Non-Committee-Global-Retrieval-Success-Rate-4c5e8c47c45f467f80392d00cac2aae4#cb14139c56b2457c9bdd750503f41b51

The reason for doing this is partly to protect clients from keeping too many requests open and to prevent SPs being able to go into "ghost mode" where they don’t get any retrieval results reported, regardless if they actually are or aren’t retrievable. They accomplish this by keeping retrieval connections open for longer than the round by making a “byte of progress every 60 seconds”. This is because Spark checkers currently only have a “progress timeout”, not a “max request duration” timeout.

@BigLep
Copy link
Author

BigLep commented Nov 1, 2024

I created this issue because I wanted to resolve this comment which had been open for over a week: https://www.notion.so/Spark-Request-Based-Non-Committee-Global-Retrieval-Success-Rate-4c5e8c47c45f467f80392d00cac2aae4?d=128837df73d480b3b108001cc60c9eb7&pvs=4#6ad4d22cf1ff4cae9458c8e9db526469

@bajtos bajtos changed the title add a client side max duration timeout Add a client side max retrieval duration timeout Nov 5, 2024
@bajtos bajtos added the good first issue 🤗 Good for newcomers label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🤗 Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants