From 4d7600e697a37a049f1ee7db88b828ef1d8cb0d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Bajto=C5=A1?= Date: Thu, 7 Mar 2024 16:45:45 +0100 Subject: [PATCH 1/2] fix: check Graphsync retrievals too MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When the storage provider does not advertise HTTP retrieval, but advertises Grapsync retrievals, then let's perform the retrieval check. This was my original intention when I implemented IPNI querying. Signed-off-by: Miroslav Bajtoš --- lib/spark.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/spark.js b/lib/spark.js index e187e2d..0862b49 100644 --- a/lib/spark.js +++ b/lib/spark.js @@ -43,7 +43,7 @@ export default class Spark { const { indexerResult, provider } = await queryTheIndex(retrieval.cid) stats.indexerResult = indexerResult - if (indexerResult !== 'OK') return + if (indexerResult !== 'OK' && indexerResult !== 'HTTP_NOT_ADVERTISED') return stats.protocol = provider.protocol stats.providerAddress = provider.address From 81b0c89209f9bbdceccb6660ed26a9c18a7f1dfb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Bajto=C5=A1?= Date: Fri, 8 Mar 2024 09:15:14 +0100 Subject: [PATCH 2/2] fixup! code cleanup MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Miroslav Bajtoš --- lib/spark.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/spark.js b/lib/spark.js index 0862b49..71e0bdc 100644 --- a/lib/spark.js +++ b/lib/spark.js @@ -43,7 +43,8 @@ export default class Spark { const { indexerResult, provider } = await queryTheIndex(retrieval.cid) stats.indexerResult = indexerResult - if (indexerResult !== 'OK' && indexerResult !== 'HTTP_NOT_ADVERTISED') return + const providerFound = indexerResult === 'OK' || indexerResult === 'HTTP_NOT_ADVERTISED' + if (!providerFound) return stats.protocol = provider.protocol stats.providerAddress = provider.address