Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add birthtime to file node layout for file creation time #737

Open
humphd opened this issue Feb 7, 2019 · 2 comments
Open

Add birthtime to file node layout for file creation time #737

humphd opened this issue Feb 7, 2019 · 2 comments

Comments

@humphd
Copy link
Contributor

humphd commented Feb 7, 2019

Our filenode layout includes atime, mtime, and ctime. We don't have birthtime. See https://nodejs.org/api/fs.html#fs_stat_time_values. We'd also need to add this to Stats as birthtime and birthtimeMs.

This would be a breaking change, requiring us to substitute something like ctime in older versions of a filesystem.

@andrewkoung
Copy link
Contributor

@humphd I'm currently analyzing this issue out of interest if you don't mind cause maybe I'll understand the purpose of the project since I still don't. I took a look into the node.js and stats.js files though since they seemed to be the place where the additions will happen, but wanted to know the significance of these files.

@humphd
Copy link
Contributor Author

humphd commented Feb 28, 2019

The idea of this would be that when we create a file node, in addition to setting the atime, mtime, and ctime, we'd also add birthtime and it would never change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants