Re

Author: 0x5bfa

src/Files.App.Storage/Windows/Managers/STATask.cs

@@ -7,11 +7,17 @@
 namespace Files.App.Storage
 {
 	/// <summary>
-	/// Represents a synchronous/asynchronous operation on STA.
+	/// Represents a work scheduled to execute on a STA thread.
 	/// </summary>
 	public partial class STATask
 	{
-		public static Task Run(Action action, ILogger? logger = null)
+		/// <summary>
+		/// Schedules the specified work to execute in a new background thread initialized with STA state.
+		/// </summary>
+		/// <param name="action">The work to execute in the STA thread.</param>
+		/// <param name="logger">A logger to capture any exception that occurs during execution.</param>
+		/// <returns>A <see cref="Task"/> that represents the work scheduled to execute in the STA thread.</returns>
+		public static Task Run(Action action, ILogger logger)
 		{
 			var tcs = new TaskCompletionSource();
 
@@ -29,7 +35,6 @@ public static Task Run(Action action, ILogger? logger = null)
 					{
 						tcs.SetResult();
 						logger?.LogWarning(ex, "An exception was occurred during the execution within STA.");
-						tcs.SetException(ex);
 					}
 					finally
 					{
@@ -44,7 +49,14 @@ public static Task Run(Action action, ILogger? logger = null)
 			return tcs.Task;
 		}
 
-		public static Task<T> Run<T>(Func<T> func, ILogger? logger = null)
+		/// <summary>
+		/// Schedules the specified work to execute in a new background thread initialized with STA state.
+		/// </summary>
+		/// <typeparam name="T">The type of the result returned by the function.</typeparam>
+		/// <param name="func">The work to execute in the STA thread.</param>
+		/// <param name="logger">A logger to capture any exception that occurs during execution.</param>
+		/// <returns>A <see cref="Task"/> that represents the work scheduled to execute in the STA thread.</returns>
+		public static Task<T> Run<T>(Func<T> func, ILogger logger)
 		{
 			var tcs = new TaskCompletionSource<T>();
 
@@ -61,7 +73,6 @@ public static Task<T> Run<T>(Func<T> func, ILogger? logger = null)
 					{
 						tcs.SetResult(default!);
 						logger?.LogWarning(ex, "An exception was occurred during the execution within STA.");
-						tcs.SetException(ex);
 					}
 					finally
 					{
@@ -76,7 +87,13 @@ public static Task<T> Run<T>(Func<T> func, ILogger? logger = null)
 			return tcs.Task;
 		}
 
-		public static Task Run(Func<Task> func, ILogger? logger = null)
+		/// <summary>
+		/// Schedules the specified work to execute in a new background thread initialized with STA state.
+		/// </summary>
+		/// <param name="func">The work to execute in the STA thread.</param>
+		/// <param name="logger">A logger to capture any exception that occurs during execution.</param>
+		/// <returns>A <see cref="Task"/> that represents the work scheduled to execute in the STA thread.</returns>
+		public static Task Run(Func<Task> func, ILogger logger)
 		{
 			var tcs = new TaskCompletionSource();
 
@@ -94,7 +111,6 @@ public static Task Run(Func<Task> func, ILogger? logger = null)
 					{
 						tcs.SetResult();
 						logger?.LogWarning(ex, "An exception was occurred during the execution within STA.");
-						tcs.SetException(ex);
 					}
 					finally
 					{
@@ -109,7 +125,14 @@ public static Task Run(Func<Task> func, ILogger? logger = null)
 			return tcs.Task;
 		}
 
-		public static Task<T?> Run<T>(Func<Task<T>> func, ILogger? logger = null)
+		/// <summary>
+		/// Schedules the specified work to execute in a new background thread initialized with STA state.
+		/// </summary>
+		/// <typeparam name="T">The type of the result returned by the function.</typeparam>
+		/// <param name="func">The work to execute in the STA thread.</param>
+		/// <param name="logger">A logger to capture any exception that occurs during execution.</param>
+		/// <returns>A <see cref="Task"/> that represents the work scheduled to execute in the STA thread.</returns>
+		public static Task<T?> Run<T>(Func<Task<T>> func, ILogger logger)
 		{
 			var tcs = new TaskCompletionSource<T?>();
 
@@ -126,7 +149,6 @@ public static Task Run(Func<Task> func, ILogger? logger = null)
 					{
 						tcs.SetResult(default);
 						logger?.LogWarning(ex, "An exception was occurred during the execution within STA.");
-						tcs.SetException(ex);
 					}
 					finally
 					{