- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.5k
 
Fix: Fixed an issue where incorrect actions were displayed in the Recycle Bin context menu #17813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed an issue where incorrect actions were displayed in the Recycle Bin context menu #17813
Conversation
| 
           Thank you for the PR. Would it be possible to set the IsExecutable property from the actions code? Otherwise, these actions will still be available from the Command Palette.  | 
    
…ution in Recycle Bin via Command Palette.
          
 Thank you for the feedback! I've updated the code to set the IsExecutable property.  | 
    
        
          
                src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …actory and to handle by IsExecutable in the respective action classes.
        
          
                src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Fixed an issue where the context menu displayed inappropriate navigation and action options for items in the Recycle Bin. Since items in the Recycle Bin cannot be properly navigated or used until restored, the following menu items are now hidden when right-clicking Recycle Bin items:
Steps used to test these changes