Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide bot.start() without run_forever() #40

Open
toppk opened this issue Oct 16, 2023 · 1 comment
Open

provide bot.start() without run_forever() #40

toppk opened this issue Oct 16, 2023 · 1 comment

Comments

@toppk
Copy link

toppk commented Oct 16, 2023

I have other things I do in the main task, and I rather not create another task just for the bot. Is there anyway to have a way to run_forever kwargs that I can skip that command?

For example, in signalbot/bot.py

class SignalBot:
    ...

    def start(run_forever=True):
         ...
         if run_fovever:
             self._event_loop.run_forever()
@filipre
Copy link
Owner

filipre commented May 29, 2024

Hi! That's a good point. I might introduce an alternative method instead for this use case instead of adding an argument. I may refactor the bot API a bit and then take this into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants