Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round of perf optimization #24

Open
film42 opened this issue Jan 29, 2023 · 2 comments
Open

Round of perf optimization #24

film42 opened this issue Jan 29, 2023 · 2 comments

Comments

@film42
Copy link
Owner

film42 commented Jan 29, 2023

This library is in a really good place, but I'm always interested in making it faster. If you have experience optimizing rust code, please take a look at this repo. We do a lot of Arc cloning and data copies through the worker flow. I'm sure there are some good ways to clean that up. If you're interested, take a stab and open a PR! <3

@jondot
Copy link
Contributor

jondot commented Oct 24, 2023

Hi @film42 i'm just evaluating this lib. I can tell you that for your typical background jobs, the optimizations you're looking for aren't needed at this point, both from Rust's point of view, the workloads expected, and being familiar with background job frameworks that I've built myself in the past.

@film42
Copy link
Owner Author

film42 commented Oct 24, 2023

Thanks for evaluating the lib, @jondot ! Let me know if you have any suggestions. I agree that throughput is 👌, but once async traits become stable (hopefully by end of year) I expect a little more throughput and maybe even fewer calls to .clone() which will be nice. But, as you said, for most background job workloads, this library is already in a great place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants