You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@vkostyukov I started working on this one but I think some guidance on how you want the API to look would be useful. As of right now I see three possible high level ways to make this change:
either add default values to API methods https://github.com/hderms/finch/blob/master/core/src/main/scala/io/finch/EndpointModule.scala#L367
or adding additional method signatures (i.e. clone each api method dealing with multipart uploads and add a StorageUnit argument). Imo this is ugly but simple to understand. Also simple to deprecate particular variants of the API methods if we went with the additional method signatures approach.
Some kind of implicit parameter which you could provide your own instance of, which seems like a lot of machinery and doesn't seem correct from a design perspective
If you could push me in the right direction that would be appreciated. Thanks
It was asked on Gitter. Here is the argument we need to wire: https://github.com/twitter/finagle/blob/develop/finagle-base-http/src/main/scala/com/twitter/finagle/http/exp/MultipartDecoder.scala#L20
The text was updated successfully, but these errors were encountered: