Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting additional Charsets #73

Open
penland365 opened this issue Jun 28, 2016 · 1 comment
Open

Supporting additional Charsets #73

penland365 opened this issue Jun 28, 2016 · 1 comment

Comments

@penland365
Copy link
Contributor

From #72 , @jeremyrsmith raises a question about supporting additional Charsets for Postgres. Currently we are locked in to StandardCharsets.UTF_8 throughout the code base.

Postgres gives us the current encoding of the Server through a Parameter Status update which can come at any point during the connection.

The question I have going forward - is this something we should automatically detect from Postgres and attempt to make it transparent to a user? Or should we set the encoding through Stack.Param configuration and immediately close the connection if the encoding ever changes from the Server?

@jeremyrsmith
Copy link

I think a good first step would be to proliferate a Charset everywhere that decoding needs to be done. For now we could just hard-code StandardCharsets.UTF_8 in those positions, but having them available and used inside decoders will make it possible to support dynamic Charsets either by reading it from the server or allowing the user to specify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants