Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix setFieldData function calling in example from README.md #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonatanSalas
Copy link

This is only a fix related to how setFieldData function is intended to work.

When using this library in combination with React Final Form, I used the setFieldData call as in the example presented in the README.md, but it wasn't working as expected, after reading the code of this mutator, I found that it checks whether the field exists, so, if call this before a field is already registered, the mutator call won't work.

Hope this helps for people trying to use this library.

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           5      5           
  Branches        1      1           
=====================================
  Hits            5      5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5daa282...19474d1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant